alamb commented on pull request #1021:
URL: https://github.com/apache/arrow-rs/pull/1021#issuecomment-991226859
My performance tests showed no significant performance difference
1. `tustvold/simplify-record-reader` @
290b24f7d1845b4cfe58eefeb6562e4ec2d54829
2. `apache/master` @ e0abda2c178be0c38d4257d22de2e4a3bfafde82
Test command
```shell
cargo bench -p parquet --bench arrow_array_reader --features=test_common --
--save-baseline <name>
```
Result:
```
alamb@instance-1:/data/arrow-rs$ critcmp master1 simplify-record-reader1
group
master1 simplify-record-reader1
-----
------- -----------------------
arrow_array_reader/read Int32Array, dictionary encoded, mandatory, no NULLs
- new 1.00 109.2±0.33µs ? ?/sec 1.00 109.0±0.31µs ?
?/sec
arrow_array_reader/read Int32Array, dictionary encoded, mandatory, no NULLs
- old 1.00 37.5±0.15µs ? ?/sec 1.00 37.6±0.19µs ?
?/sec
arrow_array_reader/read Int32Array, dictionary encoded, optional, half NULLs
- new 1.02 279.6±0.59µs ? ?/sec 1.00 275.0±1.73µs ?
?/sec
arrow_array_reader/read Int32Array, dictionary encoded, optional, half NULLs
- old 1.00 258.4±0.74µs ? ?/sec 1.12 290.2±1.68µs ?
?/sec
arrow_array_reader/read Int32Array, dictionary encoded, optional, no NULLs -
new 1.01 132.6±0.39µs ? ?/sec 1.00 130.9±0.66µs ?
?/sec
arrow_array_reader/read Int32Array, dictionary encoded, optional, no NULLs -
old 1.00 126.4±0.74µs ? ?/sec 1.02 128.9±0.57µs ?
?/sec
arrow_array_reader/read Int32Array, plain encoded, mandatory, no NULLs - new
1.00 3.6±0.18µs ? ?/sec 1.03 3.7±0.23µs ?
?/sec
arrow_array_reader/read Int32Array, plain encoded, mandatory, no NULLs - old
1.00 5.8±0.40µs ? ?/sec 1.01 5.8±0.41µs ?
?/sec
arrow_array_reader/read Int32Array, plain encoded, optional, half NULLs -
new 1.03 225.6±0.93µs ? ?/sec 1.00 219.8±1.14µs
? ?/sec
arrow_array_reader/read Int32Array, plain encoded, optional, half NULLs -
old 1.00 242.1±0.84µs ? ?/sec 1.13 272.6±1.12µs
? ?/sec
arrow_array_reader/read Int32Array, plain encoded, optional, no NULLs - new
1.05 26.8±0.32µs ? ?/sec 1.00 25.4±0.32µs ?
?/sec
arrow_array_reader/read Int32Array, plain encoded, optional, no NULLs - old
1.00 96.0±0.86µs ? ?/sec 1.02 98.2±1.41µs ?
?/sec
arrow_array_reader/read StringArray, dictionary encoded, mandatory, no NULLs
- new 1.00 155.6±1.06µs ? ?/sec 1.01 157.1±1.18µs ?
?/sec
arrow_array_reader/read StringArray, dictionary encoded, mandatory, no NULLs
- old 1.00 1201.5±3.71µs ? ?/sec 1.00 1197.0±4.59µs ?
?/sec
arrow_array_reader/read StringArray, dictionary encoded, optional, half
NULLs - new 1.00 358.7±1.41µs ? ?/sec 1.00 358.4±2.82µs
? ?/sec
arrow_array_reader/read StringArray, dictionary encoded, optional, half
NULLs - old 1.01 1086.9±3.57µs ? ?/sec 1.00 1080.2±3.87µs
? ?/sec
arrow_array_reader/read StringArray, dictionary encoded, optional, no NULLs
- new 1.01 181.7±1.17µs ? ?/sec 1.00 179.4±1.03µs ?
?/sec
arrow_array_reader/read StringArray, dictionary encoded, optional, no NULLs
- old 1.01 1273.7±7.95µs ? ?/sec 1.00 1265.2±8.85µs ?
?/sec
arrow_array_reader/read StringArray, plain encoded, mandatory, no NULLs -
new 1.00 176.6±0.96µs ? ?/sec 1.01 177.6±1.47µs
? ?/sec
arrow_array_reader/read StringArray, plain encoded, mandatory, no NULLs -
old 1.00 1377.9±7.25µs ? ?/sec 1.02 1399.2±5.47µs
? ?/sec
arrow_array_reader/read StringArray, plain encoded, optional, half NULLs -
new 1.00 380.6±1.63µs ? ?/sec 1.00 380.0±2.58µs
? ?/sec
arrow_array_reader/read StringArray, plain encoded, optional, half NULLs -
old 1.00 1179.4±4.56µs ? ?/sec 1.00 1180.2±4.77µs
? ?/sec
arrow_array_reader/read StringArray, plain encoded, optional, no NULLs - new
1.00 206.2±1.45µs ? ?/sec 1.00 205.2±1.94µs ?
?/sec
arrow_array_reader/read StringArray, plain encoded, optional, no NULLs - old
1.00 1452.5±17.75µs ? ?/sec 1.00 1445.8±5.62µs ?
?/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
