tustvold opened a new pull request #1035:
URL: https://github.com/apache/arrow-rs/pull/1035


   # Which issue does this PR close?
   
   Closes #1034.
   
   # Rationale for this change
    
   See ticket
   
   # What changes are included in this PR?
   
   Changes StructArrayReader to not compute definition, repetition and validity 
buffers for required struct arrays. 
   
   # Are there any user-facing changes?
   
   Technically this alters the precise semantics of `ArrayReader` which is 
currently a public trait. I think this is potentially unintentional (#1032), 
but even then the documented purpose of these methods is for parent 
`ArrayReader` to handle nulls and repeated arrays. However, such a parent 
cannot exist in the altered edge-case, as otherwise the definition/repetition 
levels of the struct array would be non-zero.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to