alamb commented on pull request #984:
URL: https://github.com/apache/arrow-rs/pull/984#issuecomment-991978376


   > @alamb I thought the benefit of dictionary comparison would be that it 
would enable vectorization of key comparison (especially useful when values are 
strings), since the number of keys would usually be much larger than the number 
of values
   
   Yes that is my understanding @yordan-pavlov 
   
   > In your proposed approach vectorization of key comparison could still 
happen, but is left to the compiler (instead of using explicit vectorization 
from existing comparison kernels). 
   
   I guess I was imagining that the key comparisons would be exactly as 
vectorized as the existing comparison kernels; Specifically, in my sketch above 
there is a call to `eq_scalar` (aka an existing comparison kernel)
   
   ```rust
               eq_scalar(as_primitive_array::<T>(left.values()), right)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to