bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r767593940
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##########
@@ -583,7 +606,23 @@ struct OutputAdapter<Type, enable_if_base_binary<Type>> {
return Status::NotImplemented("NYI");
}
};
+/*
+template <typename Type>
+struct OutputAdapter<Type, enable_if_base_binary<Type>> {
+ using T = typename TypeTraits<Type>::ScalarType::ValueType;
+ template <typename Generator>
+ static Status Write(KernelContext*, Datum* out, Generator&& generator) {
+ ArrayData* out_arr = out->mutable_array();
+ auto out_data = out_arr->GetMutableValues<T>(1);
+ // TODO: Is this as fast as a more explicitly inlined function?
+ for (int64_t i = 0; i < out_arr->length; ++i) {
+ *out_data++ = generator();
+ }
+ return Status::OK();
+ }
+};
+*/
Review comment:
Yes, will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
