sunchao commented on a change in pull request #1021:
URL: https://github.com/apache/arrow-rs/pull/1021#discussion_r768126971
##########
File path: parquet/src/arrow/record_reader.rs
##########
@@ -381,32 +380,26 @@ impl<T: DataType> RecordReader<T> {
match rep_levels {
Some(buf) => {
let mut records_read = 0;
+ let mut end_of_last_record = self.num_values;
+
+ for current in self.num_values..self.values_written {
+ if buf[current] == 0 && current != end_of_last_record {
Review comment:
Thanks for the context. Yea I think `consume_rep_levels` and the friends
are for assembling complex records like array, list and map. It'd be nice if we
can simplify the APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
