xudong963 commented on pull request #1437: URL: https://github.com/apache/arrow-datafusion/pull/1437#issuecomment-993464972
> * Converts a `panic!` into an `Error` in some (very important) > * Allows the user to set a higher stack limit (but overflows are still possible) Very nice conclusion, You said what I was thinking inside👍 > The thing I worry about with the approach in this PR is that it relies on us annotating all places in the code (both that currently exist as well as may be added in the future) that do recursive walks of the tree with `maybe_grow`). It seems almost inevitable that we will end up missing some and I do think this code will likely add a non trivial overhead to datafusion) > > > Yes, I agree. So I think we may check the depth of exprs using `safe_recursion` in `datafusion/src/sql/planner.rs`, then we can avoid using `may_growth` in the follow-up process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
