liyafan82 commented on a change in pull request #10114:
URL: https://github.com/apache/arrow/pull/10114#discussion_r768661679
##########
File path: cpp/src/arrow/dataset/discovery.cc
##########
@@ -210,10 +210,22 @@ Result<std::shared_ptr<DatasetFactory>>
FileSystemDatasetFactory::Make(
Result<std::shared_ptr<DatasetFactory>> FileSystemDatasetFactory::Make(
std::string uri, std::shared_ptr<FileFormat> format,
FileSystemFactoryOptions options) {
+ // TODO Partitioning support. Dictionary support should be done before that.
See
+ // ARROW-12481.
std::string internal_path;
ARROW_ASSIGN_OR_RAISE(std::shared_ptr<fs::FileSystem> filesystem,
- arrow::fs::FileSystemFromUri(uri, &internal_path))
- ARROW_ASSIGN_OR_RAISE(fs::FileInfo file_info,
filesystem->GetFileInfo(internal_path))
+ fs::FileSystemFromUri(uri, &internal_path))
+ ARROW_ASSIGN_OR_RAISE(arrow::fs::FileInfo file_info,
+ filesystem->GetFileInfo(internal_path));
Review comment:
nit: it seems we sometimes use `arrow::fs` and sometimes use `fs::`. Is
there any special reason for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
