amol- commented on a change in pull request #11659:
URL: https://github.com/apache/arrow/pull/11659#discussion_r768664725
##########
File path: python/pyarrow/tests/test_array.py
##########
@@ -732,19 +732,19 @@ def test_struct_array_sort():
{"a": 5, "b": "foo"},
]
- sorted_arr = arr.sort("descending")
+ sorted_arr = arr.sort("ascending", fieldname="b")
Review comment:
This should be revert to omit the `fieldname`, it was the acceeptance
test for sorting struct arrays wiithout any specific field.
##########
File path: python/pyarrow/tests/test_array.py
##########
@@ -732,19 +732,19 @@ def test_struct_array_sort():
{"a": 5, "b": "foo"},
]
- sorted_arr = arr.sort("descending")
+ sorted_arr = arr.sort("ascending", fieldname="b")
assert sorted_arr.to_pylist() == [
- {"a": 35, "b": "foobar"},
- {"a": 7, "b": "car"},
{"a": 7, "b": "bar"},
+ {"a": 7, "b": "car"},
{"a": 5, "b": "foo"},
+ {"a": 35, "b": "foobar"},
]
- sorted_arr = arr.sort("ascending")
+ sorted_arr = arr.sort("ascending", fieldname="a")
Review comment:
This should be revert to omit the `fieldname`, it was the acceeptance
test for sorting struct arrays wiithout any specific field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
