aucahuasi commented on a change in pull request #11923:
URL: https://github.com/apache/arrow/pull/11923#discussion_r768699423
##########
File path: cpp/src/arrow/compute/exec/filter_node.cc
##########
@@ -92,10 +92,13 @@ class FilterNode : public MapNode {
return ExecBatch::Make(std::move(values));
}
- void InputReceived(ExecNode* input, ExecBatch batch) override {
+ void InputReceived(ExecNode* input, std::function<Result<ExecBatch>()> task)
override {
DCHECK_EQ(input, inputs_[0]);
- auto func = [this](ExecBatch batch) { return DoFilter(std::move(batch)); };
- this->SubmitTask(std::move(func), std::move(batch));
+ auto func = [this, task]() -> Result<ExecBatch> {
+ ARROW_ASSIGN_OR_RAISE(auto batch, task());
+ return DoFilter(std::move(batch));
+ };
+ this->SubmitTask(std::move(func));
Review comment:
That's right, that change will happen when in the PRs related to the
scheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
