hntd187 commented on a change in pull request #1448:
URL: https://github.com/apache/arrow-datafusion/pull/1448#discussion_r768857740
##########
File path: datafusion/src/physical_plan/projection.rs
##########
@@ -63,13 +63,22 @@ impl ProjectionExec {
let fields: Result<Vec<Field>> = expr
.iter()
- .map(|(e, name)| match input_schema.field_with_name(name) {
- Ok(f) => Ok(f.clone()),
- Err(_) => {
- let dt = e.data_type(&input_schema)?;
- let nullable = e.nullable(&input_schema)?;
- Ok(Field::new(name, dt, nullable))
- }
+ .map(|(e, name)| {
Review comment:
This was the question I had asked previously about when projections
created new columns, basically, it doesn't seem to make sense to just blindly
carry over metadata because it's about a column that may no longer exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
