jhorstmann commented on pull request #1039: URL: https://github.com/apache/arrow-rs/pull/1039#issuecomment-993821801
Logic looks correct to me. There is code with a similar goal already in [`transform/utils.rs`](https://github.com/apache/arrow-rs/blob/07660c61680220ac54b7bf4c42a64c840872cc43/arrow/src/array/transform/utils.rs#L39) which is used when concatenating boolean arrays and null bitmaps. That code uses chunked iteration, so in theory could append 64 bits at once, but it's also a bit more complex and indirect. Could be interesting to benchmark both approaches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
