matthewmturner commented on pull request #984: URL: https://github.com/apache/arrow-rs/pull/984#issuecomment-994078393
@alamb thank you for the additional context and all the guidance youve provided so far. just to expand on and summarize your plan to make sure im not missing any steps, can you confirm these are the steps? 1. New issue / PR to implement `IntoArrowNumericType` 2. Use 'IntoArrowNumericType' to create the different underlying `xx_dict_scalar` functions / macros. 3. We create the dynamic array kernels (i.e. `eq_dyn_scalar`) for scalar values, using the the new dict kernels create in step 2 for `DictionaryArray` (this PR) 4. We create issue for implementing the `Scalar` api 5. We create issue for creating dynamic array and scalar kernels Im happy to, and have enjoyed, working on this. but I dont want to slow down anything on the IOx side as a result of me getting up to speed on the different pieces here. If you're okay (and aligned on the steps above) with it we could continue as we have been on this, and ill start on the first step and ping you as I have questions / for guidance. If this isnt moving at a quick enough pace then we can work on plan for how you can assist on the implementation to speed it up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
