lidavidm commented on pull request #11818: URL: https://github.com/apache/arrow/pull/11818#issuecomment-994149456
I only took a quick scan but I don't see anything fundamentally wrong. - It gets confusing with all the `chrono` types but we should stick to UpperCamelCase for Arrow functions/methods - Do we want QUARTER in addition to SEASON? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org