pitrou commented on a change in pull request #11925:
URL: https://github.com/apache/arrow/pull/11925#discussion_r769744355
##########
File path: cpp/src/arrow/util/tracing_internal.cc
##########
@@ -68,15 +112,14 @@ std::unique_ptr<sdktrace::SpanExporter>
InitializeExporter() {
auto maybe_env_var = arrow::internal::GetEnvVar(kTracingBackendEnvVar);
if (maybe_env_var.ok()) {
auto env_var = maybe_env_var.ValueOrDie();
- if (env_var == "otlp_http") {
-#ifdef ARROW_WITH_OPENTELEMETRY
+ if (env_var == "ostream") {
+ return
arrow::internal::make_unique<otel::exporter::trace::OStreamSpanExporter>();
+ } else if (env_var == "otlp_http") {
namespace otlp = opentelemetry::exporter::otlp;
otlp::OtlpHttpExporterOptions opts;
return arrow::internal::make_unique<otlp::OtlpHttpExporter>(opts);
-#else
- ARROW_LOG(WARNING) << "Requested " << kTracingBackendEnvVar << "=" < < <
< env_var
- " but Arrow was not built with ARROW_WITH_OPENTELEMETRY";
-#endif
+ } else if (env_var == "arrow_otlp_stdout") {
Review comment:
Should there be, similarly, "arrow_oltp_stderr"?
(btw, what does "oltp" mean?)
##########
File path: cpp/src/arrow/util/tracing_internal.cc
##########
@@ -68,15 +112,14 @@ std::unique_ptr<sdktrace::SpanExporter>
InitializeExporter() {
auto maybe_env_var = arrow::internal::GetEnvVar(kTracingBackendEnvVar);
if (maybe_env_var.ok()) {
auto env_var = maybe_env_var.ValueOrDie();
- if (env_var == "otlp_http") {
-#ifdef ARROW_WITH_OPENTELEMETRY
+ if (env_var == "ostream") {
+ return
arrow::internal::make_unique<otel::exporter::trace::OStreamSpanExporter>();
+ } else if (env_var == "otlp_http") {
namespace otlp = opentelemetry::exporter::otlp;
otlp::OtlpHttpExporterOptions opts;
return arrow::internal::make_unique<otlp::OtlpHttpExporter>(opts);
-#else
- ARROW_LOG(WARNING) << "Requested " << kTracingBackendEnvVar << "=" < < <
< env_var
- " but Arrow was not built with ARROW_WITH_OPENTELEMETRY";
-#endif
+ } else if (env_var == "arrow_otlp_stdout") {
Review comment:
Should there be, similarly, "arrow_otlp_stderr"?
(btw, what does "otlp" mean?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
