vibhatha commented on a change in pull request #11911:
URL: https://github.com/apache/arrow/pull/11911#discussion_r770174085



##########
File path: python/pyarrow/dataset.py
##########
@@ -798,6 +800,20 @@ def write_dataset(data, base_dir, basename_template=None, 
format=None,
         used determined by the number of available CPU cores.
     max_partitions : int, default 1024
         Maximum number of partitions any batch may be written into.
+    max_open_files : int, default 1024
+        Maximum number of number of files can be opened

Review comment:
       Yes, I understand. Added the C++ full docstrings. 
   
   > Went through the tests. I had a few questions on some parts that I didn't 
understand, but I think they generally seem right.
   > 
   > If you are up for the task, I think it may be worth consolidating them so 
it's simpler to read through.
   
   Of course, I will improve the test cases. Thank you for the detailed review 
comments. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to