pitrou commented on a change in pull request #11977:
URL: https://github.com/apache/arrow/pull/11977#discussion_r770952374
##########
File path: cpp/src/arrow/filesystem/s3fs.cc
##########
@@ -1732,44 +1752,43 @@ class S3FileSystem::Impl : public
std::enable_shared_from_this<S3FileSystem::Imp
auto outcome = client_->HeadObject(req);
if (outcome.IsSuccess()) {
- *out = true;
- return Status::OK();
+ return true;
}
if (!backend_) {
SaveBackend(outcome.GetError());
Review comment:
`SaveBackend` needs to inspect the headers from an error response, hence
its signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
