edponce commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r770954431
##########
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##########
@@ -68,6 +72,50 @@ struct GreaterEqual {
}
};
+struct BetweenLessEqualLessEqual {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left <= middle) && (middle <= right);
+ }
+};
+
+struct BetweenLessThanLessEqual {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left < middle) && (middle <= right);
+ }
+};
+
+struct BetweenLessEqualLessThan {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left <= middle) && (middle < right);
+ }
+};
+
+struct BetweenLessThanLessThan {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left < middle) && (middle < right);
+ }
+};
Review comment:
I suggest to have a single `between` function that uses
`FunctionOptions` to control its behavior. These different comparisons can be
represented using an enum, which can then be used as a template parameter for
compiler to dispatch accordingly. See for example how [`round`
function](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/kernels/scalar_arithmetic.cc#L901)
is implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
