alamb commented on a change in pull request #1408:
URL: https://github.com/apache/arrow-datafusion/pull/1408#discussion_r771476436
##########
File path: datafusion/src/physical_plan/expressions/average.rs
##########
@@ -45,9 +47,10 @@ pub struct Avg {
pub fn avg_return_type(arg_type: &DataType) -> Result<DataType> {
match arg_type {
DataType::Decimal(precision, scale) => {
- // the new precision and scale for return type of avg function
- let new_precision = 38.min(*precision + 4);
- let new_scale = 38.min(*scale + 4);
+ // in the spark, the result type is DECIMAL(min(38,precision+4),
min(38,scale+4)).
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
