cyb70289 commented on a change in pull request #11864:
URL: https://github.com/apache/arrow/pull/11864#discussion_r771774845



##########
File path: cpp/src/arrow/compute/registry.cc
##########
@@ -188,6 +188,9 @@ static std::unique_ptr<FunctionRegistry> 
CreateBuiltInRegistry() {
   RegisterScalarAggregateTDigest(registry.get());
   RegisterScalarAggregateVariance(registry.get());
 
+  // Random generator function
+  RegisterRandom(registry.get());
+
   RegisterAggregateOptions(registry.get());

Review comment:
       
https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/registry.cc#L158-L191
   ```
   // scalar
   register scalar kernels
   register scalar option
   
   // vector
   register vector kernels
   register vector option
   
   // aggregate
   register agg kernels
   register agg option
   ```
   
   Looks nullary kernel doesn't fit any existing type. We can add a new type at 
the end. E.g.,
   ```
   // nullary
   RegisterNullaryRandom
   ...
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to