WillAyd commented on a change in pull request #11990:
URL: https://github.com/apache/arrow/pull/11990#discussion_r771849033
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -185,6 +191,98 @@ struct Day {
Localizer localizer_;
};
+// ----------------------------------------------------------------------
+// Extract (year, month, day) struct from temporal types
+
+template <typename Duration, typename InType, typename BuilderType>
+struct DateStructVisitValueFunction {
+ static Result<std::function<Status(typename InType::c_type arg)>> Get(
+ const std::vector<BuilderType*>& field_builders, const ArrayData&,
+ StructBuilder* struct_builder) {
+ return [=](typename InType::c_type arg) {
+ const auto ymd = year_month_day(floor<days>(NonZonedLocalizer{}.template
ConvertTimePoint<Duration>(arg)));;
+ field_builders[0]->UnsafeAppend(static_cast<const int32_t>(ymd.year()));
+ field_builders[1]->UnsafeAppend(static_cast<const
uint32_t>(ymd.month()));
+ field_builders[2]->UnsafeAppend(static_cast<const uint32_t>(ymd.day()));
+ return struct_builder->Append();
+ };
+ };
+};
+
+template <typename Duration, typename BuilderType>
+struct DateStructVisitValueFunction<Duration, TimestampType, BuilderType> {
+ static Result<std::function<Status(typename TimestampType::c_type arg)>> Get(
+ const std::vector<BuilderType*>& field_builders, const ArrayData& in,
+ StructBuilder* struct_builder) {
+ const auto& timezone = GetInputTimezone(in);
+ if (timezone.empty()) {
+ return [=](TimestampType::c_type arg) {
+ const auto ymd =
year_month_day(floor<days>(NonZonedLocalizer{}.template
ConvertTimePoint<Duration>(arg)));;
+ field_builders[0]->UnsafeAppend(static_cast<const
int32_t>(ymd.year()));
+ field_builders[1]->UnsafeAppend(static_cast<const
uint32_t>(ymd.month()));
+ field_builders[2]->UnsafeAppend(static_cast<const
uint32_t>(ymd.day()));
+ return struct_builder->Append();
+ };
+ }
+ ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
+ return [=](TimestampType::c_type arg) {
+ const auto ymd =
year_month_day(floor<days>(ZonedLocalizer{tz}.template
ConvertTimePoint<Duration>(arg)));
+ field_builders[0]->UnsafeAppend(static_cast<const
int32_t>(ymd.year()));
+ field_builders[1]->UnsafeAppend(static_cast<const
uint32_t>(ymd.month()));
+ field_builders[2]->UnsafeAppend(static_cast<const
uint32_t>(ymd.day()));
+ return struct_builder->Append();
+ };
+ }
+};
+
+template <typename Duration, typename InType>
+struct DateStruct {
+ static Status Call(KernelContext* ctx, const Scalar& in, Scalar* out) {
+ if (in.is_valid) {
+ const auto& in_val = internal::UnboxScalar<const InType>::Unbox(in);
+ const auto t = floor<days>(NonZonedLocalizer{}.template
ConvertTimePoint<Duration>(in_val));
Review comment:
Yea I was a little wary of how this handled timezones. This was copied
over from ISOCalendar, which I'm guessing may have different requirements.
Will give it another pass and see if I can match the other kernels more
closely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
