augustoasilva commented on a change in pull request #11957:
URL: https://github.com/apache/arrow/pull/11957#discussion_r772271146
##########
File path: cpp/src/gandiva/gandiva_object_cache.cc
##########
@@ -17,34 +17,25 @@
#include "gandiva/gandiva_object_cache.h"
+#include <utility>
+
namespace gandiva {
GandivaObjectCache::GandivaObjectCache(
std::shared_ptr<Cache<ExpressionCacheKey,
std::shared_ptr<llvm::MemoryBuffer>>>&
cache,
ExpressionCacheKey key)
- : cache_key_(key) {
+ : cache_key_(std::move(key)) {
Review comment:
This change us a good pratice for creating an object which has parameter
as a smart pointer. I've read about it on some online discussions. Should I
revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
