coryan commented on a change in pull request #11997:
URL: https://github.com/apache/arrow/pull/11997#discussion_r772499030



##########
File path: cpp/src/arrow/filesystem/gcsfs_test.cc
##########
@@ -797,6 +838,11 @@ TEST_F(GcsIntegrationTest, OpenInputStreamInfoInvalid) {
   ASSERT_RAISES(IOError, fs->OpenInputStream(info));
 }
 
+TEST_F(GcsIntegrationTest, OpenInputStreamUri) {
+  auto fs = internal::MakeGcsFileSystemForTest(TestGcsOptions());
+  ASSERT_RAISES(Invalid, fs->OpenInputStream("gcs:" + 
PreexistingObjectPath()));

Review comment:
       I know this is just for testing purposes, but the conventional prefix 
for GCS is `gs://`, at least that is what `gsutil` uses:
   
   https://cloud.google.com/storage/docs/gsutil#syntax
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to