amol- commented on a change in pull request #11886:
URL: https://github.com/apache/arrow/pull/11886#discussion_r773079151
##########
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##########
@@ -189,6 +191,72 @@ Status ConstBoolExec(KernelContext* ctx, const ExecBatch&
batch, Datum* out) {
return Status::OK();
}
+struct NonZeroVisitor {
+ UInt32Builder *builder;
+ const ArrayData& array;
+
+ NonZeroVisitor(UInt32Builder *builder, const ArrayData& array)
+ : builder(builder), array(array) {}
+
+ Status Visit(const DataType& type) {
+ return Status::TypeError("Unsupported type for nonzero: ",
type.ToString());
+ }
+
+ template <typename Type>
+ enable_if_t<has_c_type<Type>::value &&
+ !std::is_same<Type, MonthDayNanoIntervalType>::value &&
+ !std::is_same<Type, DayTimeIntervalType>::value,
Review comment:
:+1:, used `enable_if_t<is_primitive_ctype<Type>::value, Status>` so
that if in the future support for additional types has to be added they can
easily be `||` with the current condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
