amol- commented on a change in pull request #11886:
URL: https://github.com/apache/arrow/pull/11886#discussion_r773930228
##########
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##########
@@ -189,6 +194,73 @@ Status ConstBoolExec(KernelContext* ctx, const ExecBatch&
batch, Datum* out) {
return Status::OK();
}
+struct NonZeroVisitor {
+ UInt64Builder* builder;
+ const ArrayData& array;
+
+ NonZeroVisitor(UInt64Builder* builder, const ArrayData& array)
+ : builder(builder), array(array) {}
+
+ Status Visit(const DataType& type) { return
Status::NotImplemented(type.ToString()); }
+
+ template <typename Type>
+ enable_if_t<is_primitive_ctype<Type>::value, Status> Visit(const Type&) {
+ using T = typename GetViewType<Type>::T;
+ uint32_t index = 0;
+
+ return VisitArrayDataInline<Type>(
+ this->array,
+ [&](T v) {
+ if (v) {
+ this->builder->UnsafeAppend(index);
+ }
+ ++index;
+ return Status::OK();
+ },
+ [&]() {
+ ++index;
+ return Status::OK();
+ });
+ }
Review comment:
Good catch, it's a leftover from the previous implementation where this
block was invoking `Resize` and thus throwing a possible error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
