ianmcook commented on pull request #11904: URL: https://github.com/apache/arrow/pull/11904#issuecomment-999649600
> > It got me thinking: wouldn't it be nice if users could call any registered function by its namespace-qualified name or by its unqualified name? > > There's a JIRA on this one ([ARROW-14575](https://issues.apache.org/jira/browse/ARROW-14575))! In the PR for that JIRA we'd add the package names to all our currently registered functions, implement a slightly different registry that keeps track of packages instead of discarding it, and implement a binding for `::` that uses some registry of package functions (but the unqualified versions would still work). > > I chose to keep the namespace with the function in the same string because that's what `vctrs::s3_register()` does (i.e., you call `vctrs::s3_regsiter("pkg::fun", ...)`). The namespace could certainly be separate (`vctrs::s3_register()` used to be implemented this way)...maybe that's a good implementation detail to hash out in the PR for [ARROW-14575](https://issues.apache.org/jira/browse/ARROW-14575)? I didn't add any of the package names to `register_binding()` calls internally because that seemed easier to review as a separate PR. All sounds good to me 👍 Looks like some of the CI jobs were failing because of 404 errors from RStudio Package Manager. I restarted them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
