alamb opened a new pull request #1477:
URL: https://github.com/apache/arrow-datafusion/pull/1477
# Which issue does this PR close?
Closes #1476
# Rationale for this change
This is a regression in https://github.com/apache/arrow-datafusion/pull/1455
The following code in Sort skips the field level metadata when when it
constructs the output batch.
```rust
let schema = Arc::new(Schema::new(
schema
.fields()
.iter()
.zip(batch.columns().iter().map(|col| col.data_type()))
.map(|(field, ty)| Field::new(field.name(), ty.clone(),
field.is_nullable()))
.collect::<Vec<_>>(),
));
```
Thus the output schema is not correct.
It also seems to be unnecessary (at least all the tests pass without it, so
maybe @maxburke can comment on what problem it was solving).
@hntd187 has also added some functions working with
https://github.com/apache/arrow-rs/pull/1033 PR to add some additional
functions for creating fields and I will work on this as well
# What changes are included in this PR?
1. Remove offending code
2. add a test
# Are there any user-facing changes?
Bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
