matthewmturner commented on pull request #1074: URL: https://github.com/apache/arrow-rs/pull/1074#issuecomment-1000071551
Ive made a number of updates to simplify this, such as de-macroing a level, and have finally made our test pass. Of course there would need to be considerable cleanup to his but I think that this could demonstrate an approach to making this work. To be fair, ive thought ive been close about 5 times now and have been wrong each time so definitely happy to get more insight from others. @alamb as always your feedback greatly appreciated. @shepmaster thank you for the review before. ive cleaned up based on some of your feedback with the goal of trying to demonstrate in simpler terms (i.e. less macros) what were trying to do. im still quite new to rust so im not sure how to manage inlining `dyn_compare_scalar`. ive started to read up on it but will definitely take more time to get an understanding. If you could provide any additional color on that it would be greatly appreciated, else I can follow up once i have a better understanding). also would be interested in what @alamb has to say about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
