rok commented on pull request #11818:
URL: https://github.com/apache/arrow/pull/11818#issuecomment-1000255420


   > > At the moment some of the code (ns, us, ms, s, m, h, d, w) is UTC based 
even when timezones are present. UTC always converts to a local time so 
nonexistent is not an issue while ambiguous could be.
   > 
   > In pandas we always round in local time (some discussion about this in 
[pandas-dev/pandas#37592](https://github.com/pandas-dev/pandas/issues/37592)), 
and then you can actually run into nonexistent times as well.
   
   I'm happy to hear pandas rounds in local time! (For some reason I assumed it 
doesn't).
   
   > The reason we do this (with its limitations ..), is because not every 
timezone has an exactly rounded / hourly offset, and so because of that 
rounding can give wrong results. For example, in Australia in summer there is a 
UTC+10:30 timezone:
   
   Yeah, David raised this point too, I'll try to address it and get back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to