anthonylouisbsb commented on a change in pull request #10402:
URL: https://github.com/apache/arrow/pull/10402#discussion_r774530554
##########
File path: cpp/src/gandiva/precompiled/time_test.cc
##########
@@ -132,6 +132,44 @@ TEST(TestTime, TestCastTimestamp) {
context.Reset();
}
+TEST(TestTime, TestCastTimeUtf8) {
+ ExecutionContext context;
+ auto context_ptr = reinterpret_cast<int64_t>(&context);
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "9:45:30", 7), 35130000);
+ EXPECT_EQ(castTIME_utf8(context_ptr, "9:45:30.920", 11), 35130920);
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "9:45:30.1", 9),
+ castTIME_utf8(context_ptr, "9:45:30", 7) + 100);
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "9:45:30.10", 10),
+ castTIME_utf8(context_ptr, "9:45:30", 7) + 100);
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "9:45:30.100", 11),
+ castTIME_utf8(context_ptr, "9:45:30", 7) + 100);
+
+ // error cases
+ EXPECT_EQ(castTIME_utf8(context_ptr, "24:00:00", 8), 0);
+ EXPECT_EQ(context.get_error(), "Not a valid time value 24:00:00");
+ context.Reset();
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "00:60:00", 8), 0);
+ EXPECT_EQ(context.get_error(), "Not a valid time value 00:60:00");
+ context.Reset();
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "00:00:100", 9), 0);
+ EXPECT_EQ(context.get_error(), "Not a valid time value 00:00:100");
+ context.Reset();
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "00:00:00.0001", 13), 0);
+ EXPECT_EQ(context.get_error(), "Invalid millis for time value
00:00:00.0001");
+ context.Reset();
+
+ EXPECT_EQ(castTIME_utf8(context_ptr, "00:00:00.1000", 13), 0);
+ EXPECT_EQ(context.get_error(), "Invalid millis for time value
00:00:00.1000");
Review comment:
I add error for invalid character
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
