lidavidm commented on a change in pull request #12000:
URL: https://github.com/apache/arrow/pull/12000#discussion_r774614012
##########
File path: cpp/src/arrow/type.cc
##########
@@ -275,6 +256,429 @@ std::shared_ptr<Field> Field::WithNullable(const bool
nullable) const {
return std::make_shared<Field>(name_, type_, nullable, metadata_);
}
+Field::MergeOptions Field::MergeOptions::Permissive() {
+ MergeOptions options = Defaults();
+ options.promote_nullability = true;
+ options.promote_numeric_width = true;
+ options.promote_integer_float = true;
+ options.promote_integer_decimal = true;
+ options.promote_decimal_float = true;
+ options.promote_date = true;
+ options.promote_time = true;
+ options.promote_duration = true;
+ options.promote_timestamp = true;
+ options.promote_nested = true;
+ options.promote_dictionary = true;
+ options.promote_integer_sign = true;
+ options.promote_large = true;
+ options.promote_binary = true;
+ return options;
Review comment:
Whoops, I didn't update this after adding some of the additional
options. I'll document what's not enabled as you suggest, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
