[GitHub] [arrow] rafael-telles commented on pull request #12013: ARROW-14421: [C++] Implement Flight SQL

[GitBox]

rafael-telles commented on pull request #12013:
URL: https://github.com/apache/arrow/pull/12013#issuecomment-1000356421


   Thanks @lidavidm ! Looks like there is only one place we didn't explicitly 
use `arrow::Result`, this patch should fix it:
   
   ```diff
   diff --git 
a/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc 
b/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc
   index a5824ae255..08a03c4ca6 100644
   --- a/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc
   +++ b/cpp/src/arrow/flight/sql/example/sqlite_statement_batch_reader.cc
   @@ -93,8 +93,8 @@ SqliteStatementBatchReader::SqliteStatementBatchReader(
          rc_(SQLITE_OK),
          already_executed_(false) {}
    
   -Result<std::shared_ptr<SqliteStatementBatchReader>> 
SqliteStatementBatchReader::Create(
   -    const std::shared_ptr<SqliteStatement>& statement_) {
   +arrow::Result<std::shared_ptr<SqliteStatementBatchReader>>
   +SqliteStatementBatchReader::Create(const std::shared_ptr<SqliteStatement>& 
statement_) {
      ARROW_RETURN_NOT_OK(statement_->Step());
    
      ARROW_ASSIGN_OR_RAISE(auto schema, statement_->GetSchema());
   ```
   
   Do you prefer I open another PR for this?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org