WillAyd commented on pull request #11990: URL: https://github.com/apache/arrow/pull/11990#issuecomment-1000615827
Alright so I have this to a point where ISOCalendar and YearMonthDay are practically mirror images of one another, save different implementations of a `GetX` function. In terms of more code sharing my first thought was to move some of the Wrapper / Visit functions in as struct members to both ISOCalendar and YearMonthDay. I'm brand new to C++ though so if there's a more idiomatic approach you had in mind let me know and happy to work on that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
