domoritz commented on pull request #10371:
URL: https://github.com/apache/arrow/pull/10371#issuecomment-1000939080


   Something is seriously wrong here. I had to add this hack to make webpack 
use the .mjs files: [`90c3d10` 
(#10371)](https://github.com/apache/arrow/pull/10371/commits/90c3d10c9dc19eb79fb88db493dd8dd2a10738ff#diff-23cb0b449c78051aa18441d6a40c0230beaef5b68c004c76d64f8b66d34e8043R29).
 
   
   Even after this hack, webpack still does not tree shake. 
   
   ```
   $ webpack --config test/bundle/webpack-test/webpack.config.js
   asset makeTable-bundle.js 310 KiB [emitted] (name: makeTable)
   asset vector-bundle.js 310 KiB [emitted] (name: vector)
   asset table-bundle.js 310 KiB [emitted] (name: table)
   orphan modules 348 KiB [orphan] 46 modules
   runtime modules 1.16 KiB 6 modules
   cacheable modules 247 KiB
     modules by path ./targets/apache-arrow/ 236 KiB
       modules by path ./targets/apache-arrow/util/*.mjs 52.6 KiB 11 modules
       modules by path ./targets/apache-arrow/*.mjs 119 KiB 9 modules
       modules by path ./targets/apache-arrow/visitor/*.mjs 47.9 KiB 7 modules
       modules by path ./targets/apache-arrow/row/*.mjs 8.07 KiB 2 modules
       modules by path ./targets/apache-arrow/builder/*.mjs 8.14 KiB
         ./targets/apache-arrow/builder/buffer.mjs 5.78 KiB [built] [code 
generated]
         ./targets/apache-arrow/builder/valid.mjs 2.36 KiB [built] [code 
generated]
     modules by path ./test/bundle/webpack-test/*.js 124 bytes
       ./test/bundle/webpack-test/table.js 58 bytes [built] [code generated]
       ./test/bundle/webpack-test/makeTable.js 66 bytes [built] [code generated]
     ./node_modules/tslib/tslib.es6.js 11.5 KiB [built] [code generated]
   webpack 5.65.0 compiled successfully in 230 ms
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to