edponce commented on pull request #12036: URL: https://github.com/apache/arrow/pull/12036#issuecomment-1002243877
I think public constructors should perform validation to minimize incorrect use of data structures. If we make `ChunkedArray` constructors protected then we would need to modify all the calls to `std::make_shared<ChunkedArray>()` for `ChunkedArray::Make()`. This will still incur in the validation overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
