alamb commented on a change in pull request #1095:
URL: https://github.com/apache/arrow-rs/pull/1095#discussion_r776322444
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -1496,6 +1553,16 @@ mod tests {
};
}
+ /// Evaluate `KERNEL` with two vectors as inputs and assert against the
expected output.
+ /// `A_VEC` and `B_VEC` can be of type `Vec<i64>` or `Vec<Option<i64>>`.
+ /// `EXPECTED` can be either `Vec<bool>` or `Vec<Option<bool>>`.
+ /// The main reason for this macro is that inputs and outputs align nicely
after `cargo fmt`.
+ macro_rules! cmp_i64 {
Review comment:
this is a nice refactor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
