edponce commented on a change in pull request #12032:
URL: https://github.com/apache/arrow/pull/12032#discussion_r776423102
##########
File path: cpp/src/arrow/compute/kernels/row_encoder.h
##########
@@ -231,6 +231,26 @@ struct VarLengthKeyEncoder : KeyEncoder {
std::shared_ptr<DataType> type_;
};
+struct NullKeyEncoder : KeyEncoder {
+ void AddLength(const Datum&, int64_t batch_length, int32_t* lengths)
override {
+ return;
+ }
Review comment:
No need to `return` as it is a void method, empty braces will suffice.
##########
File path: cpp/src/arrow/compute/kernels/row_encoder.h
##########
@@ -231,6 +231,26 @@ struct VarLengthKeyEncoder : KeyEncoder {
std::shared_ptr<DataType> type_;
};
+struct NullKeyEncoder : KeyEncoder {
+ void AddLength(const Datum&, int64_t batch_length, int32_t* lengths)
override {
+ return;
+ }
Review comment:
Similarly, for `AddLengthNull` and `EncodeNull`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
