pitrou commented on pull request #12054:
URL: https://github.com/apache/arrow/pull/12054#issuecomment-1003030568
Note that this produces a moderate performance regression, but avoiding
fragile seed behaviour seems important:
```
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Non-regressions: (2)
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline contender change %
counters
RandomKernelSeed/1 1.237M items/sec 1.191M items/sec -3.779
{'family_index': 1, 'per_family_instance_index': 0, 'run_name':
'RandomKernelSeed/1', 'repetitions': 3, 'repetition_index': 2, 'threads': 1,
'iterations': 854391}
RandomKernelSystem/1 1.208M items/sec 1.161M items/sec -3.875
{'family_index': 0, 'per_family_instance_index': 0, 'run_name':
'RandomKernelSystem/1', 'repetitions': 3, 'repetition_index': 2, 'threads': 1,
'iterations': 832333}
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Regressions: (6)
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
benchmark baseline contender change %
counters
RandomKernelSystem/64 70.753M items/sec 66.930M items/sec -5.403
{'family_index': 0, 'per_family_instance_index': 1, 'run_name':
'RandomKernelSystem/64', 'repetitions': 3, 'repetition_index': 2, 'threads': 1,
'iterations': 761829}
RandomKernelSeed/64 72.414M items/sec 68.325M items/sec -5.647
{'family_index': 1, 'per_family_instance_index': 1, 'run_name':
'RandomKernelSeed/64', 'repetitions': 3, 'repetition_index': 0, 'threads': 1,
'iterations': 780859}
RandomKernelSystem/1024 464.748M items/sec 405.753M items/sec -12.694
{'family_index': 0, 'per_family_instance_index': 2, 'run_name':
'RandomKernelSystem/1024', 'repetitions': 3, 'repetition_index': 2, 'threads':
1, 'iterations': 318463}
RandomKernelSeed/1024 469.965M items/sec 409.407M items/sec -12.886
{'family_index': 1, 'per_family_instance_index': 2, 'run_name':
'RandomKernelSeed/1024', 'repetitions': 3, 'repetition_index': 1, 'threads': 1,
'iterations': 320469}
RandomKernelSeed/65536 742.471M items/sec 612.071M items/sec -17.563
{'family_index': 1, 'per_family_instance_index': 3, 'run_name':
'RandomKernelSeed/65536', 'repetitions': 3, 'repetition_index': 0, 'threads':
1, 'iterations': 7800}
RandomKernelSystem/65536 742.684M items/sec 609.872M items/sec -17.883
{'family_index': 0, 'per_family_instance_index': 3, 'run_name':
'RandomKernelSystem/65536', 'repetitions': 3, 'repetition_index': 0, 'threads':
1, 'iterations': 7886}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
