edponce commented on pull request #11882: URL: https://github.com/apache/arrow/pull/11882#issuecomment-1003181836
@bkmgit The issue with options is not the number of distinct parameters. `FunctionOptions` can have arbitrary number of parameters. The issue is more general than that. If compute functions were to be consolidated, then `FunctionOptions` would need to have a hierarchical structure as well. This results in more complexity and less flexibility on the core C++ implementation. In fact, it would make adding functions more difficult. Also, I would argue that for other language bindings their is no inherent benefit of one versus the other. You will still need a binding per function-options combination. If you want to discuss the structure of compute functions further, I suggest you to propose an approach in ML. This would allow more visibility in the discussion and gather more opinions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
