renato2099 commented on pull request #1510: URL: https://github.com/apache/arrow-datafusion/pull/1510#issuecomment-1003269460
hey @Jimexist , I added additional tests, let me know if you think I should add some more. Btw there is one thing I wasn't very happy about and it is the fact that the current implementation takes only `f64` but I am not sure if we want to also allow integers as possible input. Anyway, let me know what you think @Jimexist ! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
