paddyhoran commented on a change in pull request #885:
URL: https://github.com/apache/arrow-rs/pull/885#discussion_r777135300
##########
File path: arrow/src/array/array_union.rs
##########
@@ -48,15 +48,15 @@ impl UnionArray {
/// caller and assumes that each of the components are correct and
consistent with each other.
/// See `try_new` for an alternative that validates the data provided.
///
- /// # Data Consistency
+ /// # Safety
///
/// The `type_ids` `Buffer` should contain `i8` values. These values
should be greater than
/// zero and must be less than the number of children provided in
`child_arrays`. These values
/// are used to index into the `child_arrays`.
///
/// The `value_offsets` `Buffer` is only provided in the case of a dense
union, sparse unions
- /// should use `None`. If provided the `value_offsets` `Buffer` should
contain `i32` values.
Review comment:
I think you removed the period at the end of this line by mistake, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
