yordan-pavlov commented on issue #1111:
URL: https://github.com/apache/arrow-rs/issues/1111#issuecomment-1003718555


   UPDATE: performance degradation after the fix is actually not so bad - only 
between 3% and 8% 
   ```
   arrow_array_reader/read StringArray, plain encoded, optional, half NULLs - 
old
                           time:   [1.4393 ms 1.4485 ms 1.4585 ms]
                           change: [-9.2499% -3.6008% +1.8053%] (p = 0.23 > 
0.05)
   arrow_array_reader/read StringArray, plain encoded, optional, half NULLs - 
new
                           time:   [594.37 us 604.91 us 618.75 us]
                           change: [+5.1998% +8.7402% +12.498%] (p = 0.00 < 
0.05)
   
   arrow_array_reader/read StringArray, dictionary encoded, optional, half 
NULLs - old
                           time:   [1.1766 ms 1.1857 ms 1.1950 ms]
                           change: [-4.5337% -2.8033% -1.0591%] (p = 0.00 < 
0.05)
   arrow_array_reader/read StringArray, dictionary encoded, optional, half 
NULLs - new
                           time:   [467.90 us 471.83 us 476.11 us]
                           change: [-0.8465% +3.1251% +7.0623%] (p = 0.12 > 
0.05)
   ```
   I will try to submit a PR for this later today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to