pitrou commented on pull request #11841:
URL: https://github.com/apache/arrow/pull/11841#issuecomment-1004068831


   The performance seems unfortunately fragile with this approach. Updated 
benchmark numbers (again):
   ```
   
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   Non-regressions: (8)
   
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                 benchmark        baseline       contender  change %            
                                                                                
                                                                     counters
   ChunkCSVVehiclesExample   1.814 GiB/sec   4.476 GiB/sec   146.729     
{'family_index': 4, 'per_family_instance_index': 0, 'run_name': 
'ChunkCSVVehiclesExample', 'repetitions': 3, 'repetition_index': 2, 'threads': 
1, 'iterations': 112}
     ChunkCSVStocksExample   1.606 GiB/sec   2.531 GiB/sec    57.540       
{'family_index': 5, 'per_family_instance_index': 0, 'run_name': 
'ChunkCSVStocksExample', 'repetitions': 3, 'repetition_index': 0, 'threads': 1, 
'iterations': 528}
   ParseCSVVehiclesExample   2.643 GiB/sec   2.831 GiB/sec     7.087     
{'family_index': 9, 'per_family_instance_index': 0, 'run_name': 
'ParseCSVVehiclesExample', 'repetitions': 3, 'repetition_index': 1, 'threads': 
1, 'iterations': 161}
      ParseCSVEscapedBlock 640.080 MiB/sec 658.864 MiB/sec     2.935       
{'family_index': 7, 'per_family_instance_index': 0, 'run_name': 
'ParseCSVEscapedBlock', 'repetitions': 3, 'repetition_index': 0, 'threads': 1, 
'iterations': 3193}
     ParseCSVStocksExample   1.264 GiB/sec   1.290 GiB/sec     2.041      
{'family_index': 10, 'per_family_instance_index': 0, 'run_name': 
'ParseCSVStocksExample', 'repetitions': 3, 'repetition_index': 1, 'threads': 1, 
'iterations': 422}
       ParseCSVQuotedBlock 830.836 MiB/sec 841.314 MiB/sec     1.261        
{'family_index': 6, 'per_family_instance_index': 0, 'run_name': 
'ParseCSVQuotedBlock', 'repetitions': 3, 'repetition_index': 1, 'threads': 1, 
'iterations': 3601}
    ParseCSVFlightsExample 500.956 MiB/sec 488.740 MiB/sec    -2.438      
{'family_index': 8, 'per_family_instance_index': 0, 'run_name': 
'ParseCSVFlightsExample', 'repetitions': 3, 'repetition_index': 0, 'threads': 
1, 'iterations': 361}
   ChunkCSVNoNewlinesBlock       103.81689      100.649114    -3.051 
{'family_index': 2, 'per_family_instance_index': 0, 'run_name': 
'ChunkCSVNoNewlinesBlock', 'repetitions': 3, 'repetition_index': 1, 'threads': 
1, 'iterations': 6787473}
   
   
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
   Regressions: (3)
   
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
                benchmark      baseline       contender  change %               
                                                                                
                                                             counters
     ChunkCSVEscapedBlock 2.050 GiB/sec   1.763 GiB/sec   -13.988  
{'family_index': 1, 'per_family_instance_index': 0, 'run_name': 
'ChunkCSVEscapedBlock', 'repetitions': 3, 'repetition_index': 1, 'threads': 1, 
'iterations': 9590}
      ChunkCSVQuotedBlock 1.531 GiB/sec   1.112 GiB/sec   -27.361   
{'family_index': 0, 'per_family_instance_index': 0, 'run_name': 
'ChunkCSVQuotedBlock', 'repetitions': 3, 'repetition_index': 0, 'threads': 1, 
'iterations': 5129}
   ChunkCSVFlightsExample 1.258 GiB/sec 921.435 MiB/sec   -28.494 
{'family_index': 3, 'per_family_instance_index': 0, 'run_name': 
'ChunkCSVFlightsExample', 'repetitions': 3, 'repetition_index': 0, 'threads': 
1, 'iterations': 943}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to