rok commented on a change in pull request #11990:
URL: https://github.com/apache/arrow/pull/11990#discussion_r777474147
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
##########
@@ -546,6 +591,23 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
auto unit = timestamp(u, "Australia/Broken_Hill");
auto month = "[1, 3, 1, 5, 1, 12, 12, 12, 1, 1, 1, 1, 12, 12, 12, 1,
null]";
auto day = "[1, 1, 1, 18, 1, 31, 30, 31, 1, 3, 4, 1, 31, 28, 29, 1, null]";
+ auto year_month_day = ArrayFromJSON(year_month_day_type,
+ R"([{"year": 1970, "month": 1, "day":
1},
+ {"year": 2000, "month": 3, "day": 1},
+ {"year": 1899, "month": 1, "day": 1},
+ {"year": 2033, "month": 5, "day": 18},
+ {"year": 2020, "month": 1, "day": 1},
+ {"year": 2019, "month": 12, "day": 31},
+ {"year": 2019, "month": 12, "day": 30},
+ {"year": 2009, "month": 12, "day": 31},
+ {"year": 2010, "month": 1, "day": 1},
+ {"year": 2010, "month": 1, "day": 3},
+ {"year": 2010, "month": 1, "day": 4},
+ {"year": 2006, "month": 1, "day": 1},
+ {"year": 2005, "month": 12, "day": 31},
+ {"year": 2008, "month": 12, "day": 28},
+ {"year": 2008, "month": 12, "day": 29},
+ {"year": 2012, "month": 1, "day": 1}, null])");
Review comment:
Looks like you could add assertions to `TestZoned2` and
`TestNonexistentTimezone` indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
