hntd187 commented on a change in pull request #1520:
URL: https://github.com/apache/arrow-datafusion/pull/1520#discussion_r778340393
##########
File path: datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -610,10 +615,14 @@ struct Accumulators {
map: RawTable<(u64, usize)>,
/// State for each group
- group_states: Vec<GroupState>,
+ //group_states: Vec<GroupState>,
+ group_states: BumpVec<'a, GroupState>,
}
-impl std::fmt::Debug for Accumulators {
+// will not be used multiple async, so Accumulators is Send
+unsafe impl Send for Accumulators<'_> {}
Review comment:
If it's not used why does it need to be `Send`? I personally prefer no
unsafe, does this work without it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
