guyuqi commented on a change in pull request #12009:
URL: https://github.com/apache/arrow/pull/12009#discussion_r778576187
##########
File path: go/arrow/math/Makefile
##########
@@ -37,27 +41,42 @@ INTEL_SOURCES := \
int64_avx2_amd64.s int64_sse4_amd64.s \
uint64_avx2_amd64.s uint64_sse4_amd64.s
+ARM_SOURCES := \
+ float64_neon_arm64.s \
+ int64_neon_arm64.s \
+ uint64_neon_arm64.s
+
.PHONEY: assembly
-assembly: $(INTEL_SOURCES)
+#ifeq ($(GOARCH), arm64)
+assembly: $(ARM_SOURCES)
+#else
+#assembly: $(INTEL_SOURCES)
+#endif
Review comment:
@zeroshade Thanks for your comments. :-)
Agreed on what you mentioned.
But after further consideration, it's noted that `c2goasm`doesn't work
correctly for Arm64.
The Arm64 assembly were generated by `asm2plan9s`, and I manually formatted
the related assembler codes.
IMO, it seems that we would not add the `assembly` target for Arm64 until
`c2goasm` added the Arm64 support.
The makefile target of assembly for `ARM_SOURCES` should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
