matthewmturner commented on a change in pull request #1131:
URL: https://github.com/apache/arrow-rs/pull/1131#discussion_r779123373
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -1448,7 +1448,82 @@ pub fn eq_dyn_bool_scalar(left: Arc<dyn Array>, right:
bool) -> Result<BooleanAr
eq_bool_scalar(left, right)
}
_ => Err(ArrowError::ComputeError(
- "Kernel only supports BooleanArray".to_string(),
+ "eq_dyn_bool_scalar only supports BooleanArray".to_string(),
+ )),
+ };
+ result
+}
+
+/// Perform `left < right` operation on an array and a numeric scalar
+/// value. Supports BooleanArrays, and DictionaryArrays that have string values
+pub fn lt_dyn_bool_scalar(left: Arc<dyn Array>, right: bool) ->
Result<BooleanArray> {
Review comment:
since this PR is for bool i think best to update the signatures in a
follow on PR. to confirm though, this would be for all dyn scalar kernels
right? scalar, utf8, and bool?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
