[GitHub] [arrow] 9prady9 commented on a change in pull request #12080: ARROW-15118: [C++] Avoid bitmap buffer if all inputs are all valid for Scalar Kernels

[GitBox]

9prady9 commented on a change in pull request #12080:
URL: https://github.com/apache/arrow/pull/12080#discussion_r779375284



##########
File path: cpp/src/arrow/compute/exec.cc
##########
@@ -370,12 +370,15 @@ class NullPropagator {
  public:
   NullPropagator(KernelContext* ctx, const ExecBatch& batch, ArrayData* output)
       : ctx_(ctx), batch_(batch), output_(output) {
+    bool are_all_ins_valids = false;
     for (const Datum& datum : batch_.values) {
       auto null_generalization = NullGeneralization::Get(datum);
 
       if (null_generalization == NullGeneralization::ALL_NULL) {
         is_all_null_ = true;
       }
+      are_all_ins_valids =
+          are_all_ins_valids && (null_generalization == 
NullGeneralization::ALL_VALID);

Review comment:
       yes, I have corrected that locally already. In fact, I have reverted 
this change. Now. I am trying to set `validity_preallocate_` inside 
`SetupPreallocation` by passing `vector<Datum> args` to it.
   
   With the new change, I am hitting some other issue - working on that 
currently




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org