jvanstraten commented on a change in pull request #12084:
URL: https://github.com/apache/arrow/pull/12084#discussion_r779405314



##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -422,7 +422,9 @@ if(ARROW_COMPUTE)
        compute/kernels/scalar_nested.cc
        compute/kernels/scalar_random.cc
        compute/kernels/scalar_set_lookup.cc
-       compute/kernels/scalar_string.cc
+       compute/kernels/scalar_string_common.cc

Review comment:
       Okay, done in 36e134b. Based on other `*_internal.h` files, I guess that 
will also satisfy the linter w.r.t. `RETURN_NOT_OK` macro usage in the 
corresponding header file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to