zeroshade commented on pull request #11538: URL: https://github.com/apache/arrow/pull/11538#issuecomment-1006659303
@emkornfield I'll update based on the comments, but as far as integration testing, currently the integration testing I have is that I use several of the test parquet files from here: https://github.com/apache/parquet-testing/tree/acd375eb86a81cd856476fca0f52ba6036a067ff/data in unit tests by setting PARQUET_TEST_DATA just like the C++ implementation. I don't think I implemented tests for *all* of the files there, but a large amount of them are currently tested, and I'll probably add more as I go. But I definitely agree that a more robust cross-implementation testing suite would be a great addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
