wjones127 commented on a change in pull request #11894:
URL: https://github.com/apache/arrow/pull/11894#discussion_r779764431
##########
File path: r/tests/testthat/test-dataset.R
##########
@@ -453,15 +453,38 @@ test_that("Creating UnionDataset", {
})
test_that("map_batches", {
- skip("map_batches() is broken (ARROW-14029)")
ds <- open_dataset(dataset_dir, partitioning = "part")
+
+ # summarize returns arrow_dplyr_query
expect_equal(
ds %>%
filter(int > 5) %>%
select(int, lgl) %>%
- map_batches(~ summarize(., min_int = min(int))),
+ map_batches(~ summarize(., min_int = min(int))) %>%
+ arrange(min_int),
tibble(min_int = c(6L, 101L))
)
+
+ # $num_rows returns integer vector
+ expect_equal(
+ ds %>%
+ filter(int > 5) %>%
+ select(int, lgl) %>%
+ map_batches(~ .$num_rows, .data.frame = FALSE) %>%
+ as.numeric() %>%
+ sort(),
+ c(5, 10)
+ )
+
+ # $Take returns RecordBatch
Review comment:
Yes, I've added a couple clarifying comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
